Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssl&proxy properties to RestSdmxClient. #157

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Mar 27, 2018

These properties are used to programmatically customize how a client access a web service.

@amattioc
Copy link
Owner

amattioc commented Apr 4, 2018

Hi @charphi , thanks for the PR.

Could you explain briefly what would be the benefits of having these properties at the client level?

Best, Attilio

@amattioc amattioc requested review from vpinna80 and removed request for vpinna80 April 4, 2018 09:51
@charphi
Copy link
Contributor Author

charphi commented Apr 4, 2018

Sure. Here is the use case:
The current system defines ssl&proxy at the application level. It means that if you configure Internet access with it, every component of the application will have that access.
I need to restrict Internet access to the SDMX client only.

@amattioc
Copy link
Owner

amattioc commented Apr 4, 2018

Thanks for the explanation.

@amattioc amattioc merged commit 798fc86 into amattioc:master Apr 4, 2018
@charphi
Copy link
Contributor Author

charphi commented Apr 18, 2018

@amattioc @vpinna80 The content of this pull request is not more available in the latest commit 5ff9020. So, I'm no more able to modify ssl&proxy by code.

@vpinna80
Copy link
Collaborator

@charphi This should be fixed now with 8ea3ccd.

@charphi
Copy link
Contributor Author

charphi commented Apr 18, 2018

Indeed, I've just tested and it works properly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants