This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
fix switched active and standby host infos #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during testing of v0.1.8 I realized that the active and standby hosts are switched in the
HostMigration
object after the migration was done, this lead to the issue that the URLs in the lagoon UI where also shown wrong.After some debugging I realized that there was probably a logic issue in the code, here what I found:
HostMigration
object in the current standby namespace, hence thesource
is the current standby and future active anddestination
is the current active and future standbymigrateDestinationToSource
is the part that moves the host from the current active (destination) to the future active (source), but we stored the routes instandbyMigratedIngress
while it should be stored inactiveMigratedIngress
migrateSourceToDestination
had it exactly switchedI pushed the fix as
amazeeio/dioscuri:v0.1.9rc1
for testing and it seems to work nicely:here an example before the fix:
and after the fix