-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1001 kubernetes cronjobs #1031
Merged
Merged
1001 kubernetes cronjobs #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schnitzel
requested changes
Apr 16, 2019
mariadb-single: Database - using mariadb direct image for Drupal containers.
Testing is done. However, CronJob version is not yet compatible for deployment with lagoon environment.tested using our helm charts..!
… On Apr 18, 2019, at 12:07 AM, Elliot Schlegelmilch ***@***.***> wrote:
@rtprio commented on this pull request.
In images/oc-build-deploy-dind/build-deploy-docker-compose.sh:
> @@ -11,6 +11,24 @@ function outputToYaml() {
set -x
}
+function checkFrequency() {
+ #takes a unexpanded cron schedule, returns true if it's less often that 15 minutes
+ MINUTE=$(echo $1 | (read -a ARRAY; echo ${ARRAY[0]}) )
+ if [[ $MINUTE =~ ^(M|H|\*)\/([0-5]?[0-9])$ ]]; then
+ STEP=${BASH_REMATCH[2]}
+ if [ $STEP -ge 15 ]; then
+ echo -n true
👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Schnitzel
force-pushed
the
1001-kubernetes-cronjobs
branch
from
May 15, 2019 20:20
4225c58
to
7b1985a
Compare
- remove service defined cronjobs and crontabs, they are all used for backups which is now handled by the BaaS system - better check of cronschedule if it is 15mins or more often
Schnitzel
force-pushed
the
1001-kubernetes-cronjobs
branch
from
May 16, 2019 21:07
735aa79
to
99f1024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cron is less often than 15 minutes, run it in a cronjob native type instead.
If the running pod has a cron [which is more frequent than 15 minutes] exclude it from the auto idler.
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Change- Don't idle pods that have cronjobs. If a cron is less often than 15 minutes, run it in a cronjob type rather than in the existing pod. ( #1001 )
Closing issues
closes #1001