Add basis rotation instructions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijc
approved these changes
Apr 27, 2020
| results: Optional[ | ||
| List[Union[Amplitude, Expectation, Probability, Sample, StateVector, Variance]] | ||
| ] | ||
| basis_rotation_instructions: Optional[List[GateInstructions]] |
There was a problem hiding this comment.
Since we only use a subset of the gates for basis rotations, do we want to restrict this to those specific gates or do we foresee having the complete set of gate instructions as being applicable?
There was a problem hiding this comment.
That's a good point. I don't want to restrict it to a subset of gates, because the transformation might be written different ways, so just leaving it as allowing all gates for now.
math411
pushed a commit
that referenced
this pull request
Feb 27, 2022
* feature: add ECR gate * spacing * fix: ECR as DoubleTarget Co-authored-by: Cody Wang <speller26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
build_files.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.