Updating the execution window hours #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalhanreddy
requested review from
avawang1,
floralph and
speller26
as code owners
|
The version should be updated to 0.2.6 |
avawang1
reviewed
Aug 4, 2020
| ... } | ||
| >>> DeviceExecutionWindow.parse_raw(json.dumps(input_json)) | ||
|
|
||
| """ | ||
|
|
||
| executionDay: ExecutionDay | ||
| windowStartHour: datetime | ||
| windowEndHour: datetime | ||
| windowStartHour: time |
There was a problem hiding this comment.
Shouldn't these be strings?
There was a problem hiding this comment.
time can be a string, You can see the examples i added. https://pydantic-docs.helpmanual.io/usage/types/#datetime-types
avawang1
reviewed
Aug 4, 2020
| @@ -114,3 +120,4 @@ class DeviceServiceProperties(BraketSchemaBase): | |||
| deviceCost: Optional[DeviceCost] | |||
| deviceDocumentation: Optional[DeviceDocumentation] | |||
| deviceLocation: Optional[str] | |||
| updatedAt: datetime | |||
There was a problem hiding this comment.
Shouldn't these be strings?
There was a problem hiding this comment.
datetime can be a string as well, please check the examples i added. https://pydantic-docs.helpmanual.io/usage/types/#datetime-types
avawang1
approved these changes
Aug 4, 2020
MattCordoba
added a commit
that referenced
this pull request
Mar 31, 2022
Update OQC json schema to match GetDevice API call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Build Results
Attach results of `tox -e zip-build
build_files.tar.gz
`
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.