Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Build) First pass over CMake #151

Merged
merged 3 commits into from Dec 3, 2019
Merged

(Build) First pass over CMake #151

merged 3 commits into from Dec 3, 2019

Conversation

therapon
Copy link
Contributor

@therapon therapon commented Dec 2, 2019

Description of changes:

  1. Requirement for CMake moves to version 3.10 (from 3.5)
  2. Adds a release target that builds and installs all libs and programs
  3. Factors CMake code into a cmake top-level folder
  4. Adds packaging for .deb and .tgz
  5. Creates IonC:: scope for CMake targets
  6. Expands source and header files, avoiding CMake GLOB which can cause issues with caching
  7. Sets correct properties for libs and uses proper install destinations

This PR does remove the generation of a static library for ionc. There are a few followup PRs planned that will address a few things, including static library generation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@therapon therapon marked this pull request as ready for review December 3, 2019 21:04
@therapon therapon merged commit 3131831 into amazon-ion:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants