Build improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create intermediate build directories * Ignore build directories in git
| #include <malloc.h> | ||
| #endif |
There was a problem hiding this comment.
My understanding is that malloc.h is an archaic header for Linux systems, and is probably not on MSVC. Perhaps we should eliminate this include all together or prefer stdlib.h
There was a problem hiding this comment.
I left it in based on the MSDN malloc docs, but I have no way to test it.
|
This looks good, thanks for doing this--I don't think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the intermediate
builddirectory before changing into it.Conditionally includes
malloc.hon Windows (malloc(3)is part ofstdlib.hin C99).Tested on: