Fix empty symbol handling and tape growth in ion-bench serialize_all benchmark. #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
This PR fixes two issues found in ion-bench's
serialize_all
benchmark.''
) as a field name. When the the ion benchmark was generating the tape from the generated data, an error in the benchmark's reader considered a >0 length symbol as an indicator that the symbol existed, rather than relying on the returned iERR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.