Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty symbol handling and tape growth in ion-bench serialize_all benchmark. #333

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Oct 19, 2023

Issue #, if available: n/a

Description of changes:
This PR fixes two issues found in ion-bench's serialize_all benchmark.

  1. While testing the performance regression workflow one of the generated datasets used an empty symbol ('') as a field name. When the the ion benchmark was generating the tape from the generated data, an error in the benchmark's reader considered a >0 length symbol as an indicator that the symbol existed, rather than relying on the returned iERR.
  2. When generating the tape for serialization, the tape was not initially cleared. This resulted in the another representation of the dataset to be appended to an existing tape of the dataset, if/when google-benchmark ran another block of iterations. This PR clears the tape for each of the formats implemented.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys nirosys marked this pull request as ready for review October 19, 2023 21:03
@nirosys nirosys merged commit bee5940 into amazon-ion:master Oct 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants