Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds From<Int> and From<UInt>` impls for Decimal #592

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

zslayton
Copy link
Contributor

@zslayton zslayton commented Jul 3, 2023

Fixes issue #582.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton marked this pull request as ready for review July 3, 2023 20:36
@zslayton zslayton requested a review from popematt July 3, 2023 20:36
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02 ⚠️

Comparison is base (1a961e9) 82.90% compared to head (f0050a2) 82.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   82.90%   82.88%   -0.02%     
==========================================
  Files         110      110              
  Lines       19248    19250       +2     
  Branches    19248    19250       +2     
==========================================
- Hits        15957    15956       -1     
- Misses       1748     1751       +3     
  Partials     1543     1543              
Impacted Files Coverage Δ
src/types/coefficient.rs 87.14% <ø> (ø)
src/types/decimal.rs 93.26% <25.00%> (-1.42%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zslayton zslayton merged commit a7e0f03 into main Jul 4, 2023
20 of 21 checks passed
@zslayton zslayton deleted the decimal-from-integers branch July 4, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants