Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kilt #317

Closed
wants to merge 1 commit into from
Closed

Upgrade kilt #317

wants to merge 1 commit into from

Conversation

veelenga
Copy link
Contributor

@veelenga veelenga commented Oct 20, 2017

Description of the Change

We have a dependency resolution problem: crystal-community/crystal-ann#58

This change should fix it and bring latest kilt features to Amber :)

Diff v0.3.3..v0.4.0.

@veelenga
Copy link
Contributor Author

veelenga commented Oct 20, 2017

There is one test failing on travis:

 1) Amber::CLI::MainCommand::Generate scaffold generates and compile generated app
 Failure/Error: File.exists?("bin/#{TESTING_APP.split("/").last}").should be_true
 Expected: true
 got: false
 # spec/amber/cli/commands/generator_spec.cr:16
Finished in 9.66 seconds
327 examples, 1 failures, 0 errors, 0 pending
Failed examples:
crystal spec spec/amber/cli/commands/generator_spec.cr:7 # Amber::CLI::MainCommand::Generate scaffold generates and compile generated app

because test_app still depends on Amber 0.3.0, which depends on kilt 0.3.3, so there is a dependency resolution problem. That test should be automatically fixed once you bump a version or prepare a new release.

Any suggestion how to let the build to pass before the merge?

@elorest
Copy link
Member

elorest commented Oct 20, 2017

Probably just merge in right before we release next.

@veelenga
Copy link
Contributor Author

Closing this in favor of #319

@veelenga veelenga closed this Oct 21, 2017
@faustinoaq faustinoaq mentioned this pull request Oct 27, 2017
6 tasks
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants