Fix version numbers #319
Merged
Fix version numbers #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eliasjpr Travis is failing Maybe |
More accurate to Command Line Interface
Closed
|
Finally works! :) |
|
@drujensen @fridgerator I think this PR is ready, WDYT? 😅 |
elorest
reviewed
Oct 23, 2017
src/amber/cli/commands/database.cr
Outdated
| @@ -19,6 +19,8 @@ module Amber::CLI | |||
| end | |||
|
|
|||
| def run | |||
| migrations_path, migrations_table_suffix = Micrate::Cli.parse_command_arguments | |||
There was a problem hiding this comment.
Why was this necessary. Looks like we're just passing commands back into Micrate that it gave us in the same scope.
There was a problem hiding this comment.
I just fixed it to work with latest version of micrate shard see: amberframework/micrate@af301fc
There was a problem hiding this comment.
I reverted these changes, please check this PR again 😄
src/amber/cli/commands/migrate.cr
Outdated
| @@ -20,25 +20,26 @@ module Amber::CLI | |||
| end | |||
|
|
|||
| def run | |||
| migrations_path, migrations_table_suffix = Micrate::Cli.parse_command_arguments | |||
There was a problem hiding this comment.
I just fixed it to work with latest version of micrate shard see: amberframework/micrate@af301fc
There was a problem hiding this comment.
I reverted these changes, please check this PR again 😄
|
|
||
| require "sentry" | ||
|
|
||
| module Sentry |
There was a problem hiding this comment.
No, It's just a helper to avoid using https://github.com/TechMagister/sentry/tree/change_cli
There was a problem hiding this comment.
I moved this file and rename to more explicit name
|
@elorest This PR is removing fork as shards successfully, Also I reverted micrate changes, (using |
|
Please squash before merge, I did more than 20 commits because I was using github from web 😅 |
eliasjpr
approved these changes
Oct 25, 2017
drujensen
approved these changes
Oct 25, 2017
|
Hey guys, can this be merged/released before crystal 0.24.0 ? |
because test_app still depends on Amber 0.3.0, which depends on kilt 0.3.3, so there is a dependency resolution problem. That test should be automatically fixed once you bump a version or prepare a new release.
This reverts commit 2bef546.
|
For some reason Amber Task merged here 👉 #318 needs a old version of However, this PR is working now 👍 We can figure out about updating new dependencies on future I will open a new issue about this 😉 |
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
* Add dependency badge * Update dependencies * Change CMD to CLI More accurate to Command Line Interface * Add sentry_command helper * Use local sentry command * Use local sentry command * Remove sentry fork * Add sentry dependency * Remove icr fork and use original repo * Update dependencies * Fix watch option * Add support for new options in Micrate::Cli * Fix wrong number of arguments for run_dbversion * Fix arguments for report_unordered_migrations * Fix & update ICR version * Update Micrate::Cli arguments * Fix micrate version * Remove parameter changes * Remove parameter changes * Moving file * Create sentry command helper * Fix require * Fix require * Update Kilt * Return old version because test_app still depends on Amber 0.3.0, which depends on kilt 0.3.3, so there is a dependency resolution problem. That test should be automatically fixed once you bump a version or prepare a new release. * Revert "Merge branch 'master' into fix-version-numbers" This reverts commit 9b27a5e, reversing changes made to b8a34f1. * Revert "Revert "Merge branch 'master' into fix-version-numbers"" This reverts commit 2bef546. * Return old version of mosop/cli
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Add dependency badge * Update dependencies * Change CMD to CLI More accurate to Command Line Interface * Add sentry_command helper * Use local sentry command * Use local sentry command * Remove sentry fork * Add sentry dependency * Remove icr fork and use original repo * Update dependencies * Fix watch option * Add support for new options in Micrate::Cli * Fix wrong number of arguments for run_dbversion * Fix arguments for report_unordered_migrations * Fix & update ICR version * Update Micrate::Cli arguments * Fix micrate version * Remove parameter changes * Remove parameter changes * Moving file * Create sentry command helper * Fix require * Fix require * Update Kilt * Return old version because test_app still depends on Amber 0.3.0, which depends on kilt 0.3.3, so there is a dependency resolution problem. That test should be automatically fixed once you bump a version or prepare a new release. * Revert "Merge branch 'master' into fix-version-numbers" This reverts commit 9b27a5e, reversing changes made to b8a34f1. * Revert "Revert "Merge branch 'master' into fix-version-numbers"" This reverts commit 2bef546. * Return old version of mosop/cli
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Add dependency badge * Update dependencies * Change CMD to CLI More accurate to Command Line Interface * Add sentry_command helper * Use local sentry command * Use local sentry command * Remove sentry fork * Add sentry dependency * Remove icr fork and use original repo * Update dependencies * Fix watch option * Add support for new options in Micrate::Cli * Fix wrong number of arguments for run_dbversion * Fix arguments for report_unordered_migrations * Fix & update ICR version * Update Micrate::Cli arguments * Fix micrate version * Remove parameter changes * Remove parameter changes * Moving file * Create sentry command helper * Fix require * Fix require * Update Kilt * Return old version because test_app still depends on Amber 0.3.0, which depends on kilt 0.3.3, so there is a dependency resolution problem. That test should be automatically fixed once you bump a version or prepare a new release. * Revert "Merge branch 'master' into fix-version-numbers" This reverts commit 943e0d1 [formerly 9b27a5e], reversing changes made to 1572211 [formerly b8a34f1]. * Revert "Revert "Merge branch 'master' into fix-version-numbers"" This reverts commit 5ce6ebc [formerly 2bef546]. * Return old version of mosop/cli Former-commit-id: 9f605f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix version numbers on
shard.ymland updates dependencieshttps://shards.rocks/github/amberframework/amber
Alternate Designs
No
Benefits
No
Possible Drawbacks
No