This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Merge tuples of transitively similar images in dictionary #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of -[OSSimilaritySearch dictionaryFromSimilarImagesResult:] does not handle tuples of transitively similar images. Consider three images A, B, and C similar to each other. Similarity search will produce the tuples (A, B), (A, C), and (B, C), which are then transformed into the dictionary representation {A: [B, C], B: [C]}, whereas one would expect a representation like {A: [B, C]}.
To handle transitivity, this patch introduces a simplified union-find-like approach (another way being, for example, traversing connected components in a graph-like structure). The optimization is possible since the similarImages* methods already return the list of tuples in a strictly ordered permutation, e. g. for the images above there cannot be a tuple (C, A).