Initial ament_cmake_google_benchmark package #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
enhancement
|
PR build will fail until ament/google_benchmark_vendor#1 is fully released. Also, we need to get ament/google_benchmark_vendor into |
dirk-thomas
reviewed
Jul 14, 2020
There was a problem hiding this comment.
PR build will fail until ament/google_benchmark_vendor#1 is fully released.
Should this PR be held until the release has happened?
Yes. This PR will not be merged until |
dirk-thomas
approved these changes
Jul 14, 2020
ament_cmake_google_benchmark/cmake/ament_add_google_benchmark_test.cmake
Outdated
Show resolved
Hide resolved
Also add `google_benchmark` label. This mirrors many other ament tests, where a label is added for a category and also for the runner mechanism. Signed-off-by: Scott K Logan <logans@cottsay.net>
This reverts part of commit eb9e292. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
google_benchmark
branch
from
c4a2c36
to
583d572
Compare
ahcorde
pushed a commit
that referenced
this pull request
Oct 2, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
ahcorde
pushed a commit
that referenced
this pull request
Oct 6, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ament/google_benchmark_vendor#1
I left the result schema conversion part of the wrapper marked with a
TODOfor now, but I'd like to make this package available right away to unblock other folks to start writing tests.