Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use IN_LIST #84

Merged
merged 1 commit into from
Jan 3, 2017
Merged

use IN_LIST #84

merged 1 commit into from
Jan 3, 2017

Conversation

dirk-thomas
Copy link
Contributor

I had to update a few packages on the way which didn't state the correct CMake minimum version yet:

Build Status

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Dec 29, 2016
@dirk-thomas dirk-thomas self-assigned this Dec 29, 2016
@dhood
Copy link
Contributor

dhood commented Jan 2, 2017

was there a particular motivation for this change (other than the obvious)? Some uses of list(FIND in this package are unchanged, e.g.

ament_cmake/ament_cmake_core/cmake/symlink_install/ament_cmake_symlink_install_files.cmake

Line 34 in 16a9281

list(FIND ARGN "${unsupported_keyword}" index)

@dirk-thomas
Copy link
Contributor Author

For the changes cases the logic is much simpler with the use of IN_LIST. The other cases also use the returned index later again so I didn't see the advantage of using it there.

dhood
dhood approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@dhood dhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm

@dirk-thomas dirk-thomas merged commit 4023091 into master Jan 3, 2017
@dirk-thomas dirk-thomas deleted the use_in_list branch January 3, 2017 00:54
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jan 3, 2017
kenji-miyake pushed a commit to kenji-miyake/ament_cmake that referenced this pull request Oct 20, 2021
@dirk-thomas
Merge pull request ament#84 from ament/use_in_list
b362e2c 
use IN_LIST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhood dhood dhood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @dhood