-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eloquent] Backport junit xml fixes for updated xunit plugin on ci.ros2.org #229
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Combined CI for both this PR and ament/ament_lint#222 Edit: re-running Windows CI without connext. Let's backport this fix first. |
@mjcarroll would you mind giving a glance at the finished test results to make sure that the test failures are accepted/acceptable for Eloquent? Windows seems to have quite a few more than the others. |
So are there test results that we weren't reporting before? These stand out to me:
There also seem to be a bunch of tests that fail with the same I don't recall seeing any of these before. |
I don't think there should be any new test results which didn't exist before. This change is only about updating the XML to comply with the latest Jenkins plugin.
You probably need to also backport ros2/launch#391. |
This is from ros2/build_farmer#255 One of the recurring challenges with running CI for older distros is that linters keep moving forward and we've previously considered linter fixes not worth backporting by themselves. I usually disregard linter failures when backporting for that reason. |
This PR along with its companion ament/ament_lint#222 should fix Eloquent CI builds failing during the test result parsing stage on ci.ros2.org.
Backports PRs #218 and #225.