-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop using constructors deprecated in pytest 5.4 #391
Conversation
rotu
commented
Mar 13, 2020
``` =============================== warnings summary =============================== /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113 /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113 /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113: PytestDeprecationWarning: direct construction of Package has been deprecated, please use Package.from_parent return pytest.Package(path, parent) /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: 37 tests with warnings /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: PytestDeprecationWarning: direct construction of Module has been deprecated, please use Module.from_parent return pytest.Module(path, parent) -- Docs: https://docs.pytest.org/en/latest/warnings.html ================= 324 passed, 39 warnings in 66.09s (0:01:06) ================== ``` Signed-off-by: Dan Rose <dan@digilabs.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minimal comments, otherwise LGTM!
@rotu friendly ping. |
Signed-off-by: Dan Rose <dan@digilabs.io>
Thanks! I left my Linux box at the office and forgot to push before I went into self-quarantine. I grabbed the computer, sterilized this commit, and pushed. |
🤣 |
Failure is unrelated, see ros2/launch_ros#128 (comment). |
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
…391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) (#459) * stop using constructors deprecated in pytest 5.4 (#391) Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Switch to from_parent to remove deprecation warning. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * avoid deprecation warning, use from_parent (#402) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Dan Rose <rotu@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>