ament_cmake_vendor_package: Switch to CMake 'bracket arguments' #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syntax behaves like a verbatim text block. Previously, escape sequences and characters which require escaping which were present in any of these variables could result in a broken configuration. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
changed the title
|
clalancette
approved these changes
Jun 20, 2023
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
This syntax behaves like a verbatim text block. Previously, escape sequences and characters which require escaping which were present in any of these variables could result in a broken configuration. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 75a74e2)
cottsay
added a commit
that referenced
this pull request
Jun 20, 2023
…#465) This syntax behaves like a verbatim text block. Previously, escape sequences and characters which require escaping which were present in any of these variables could result in a broken configuration. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 75a74e2) Co-authored-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syntax behaves like a verbatim text block. Previously, escape sequences and characters which require escaping which were present in any of these variables could result in a broken configuration.
For example, the rosbag2 CI specifies
-DCMAKE_CXX_FLAGS="-Werror", which is a valid configuration. This gets expanded in the cache file toset(CMAKE_CXX_FLAGS ""-Werror"" CACHE INTERNAL ""), which is interpreted as;-Werror""instead of"-Werror".This should resolve the CI failure in ros2/rosbag2#1400.
https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#bracket-argument