More specific prefix in some cmake_parse_argument calls

[eggerk]

The macro ament_auto_package doesn't properly pass on the additional arguments to ament_package. The reason is that the call to the macro ament_execute_extensions again calls cmake_parse_arguments with the same variable prefix, effectively overwriting the original _ARG_UNPARSED_ARGUMENTS variable and leaving it empty.

I have found this issue to be present both in galactic (which I'm aware is already EOL) and rolling.

As a fix, I renamed changed the prefix argument for cmake_parse_arguments to have unique and non-conflicting variable names in both these macros.

[sloretz]

LGTM with green CI

[sloretz]

CI (repos file build: --packages-up-to rcl ament_cmake_auto test: --packages-up-to rcl ament_cmake_auto)

• Linux
• Linux-aarch64
• Windows

[sloretz]

I think the test failures on aarch64 are unrelated, but I'll have to wait to merge this PR until after the freeze: https://discourse.ros.org/t/freeze-of-ros-2-base-packages-upcoming-branch-and-tutorial-party-for-jazzy-jalisco/37191/2

[clalancette]

I think the test failures on aarch64 are unrelated, but I'll have to wait to merge this PR until after the freeze: https://discourse.ros.org/t/freeze-of-ros-2-base-packages-upcoming-branch-and-tutorial-party-for-jazzy-jalisco/37191/2

Yes, they are unrelated. Going ahead and merging this one in.

[sloretz]

@Mergifyio backport iron humble jazzy

[mergify]

backport iron humble jazzy

✅ Backports have been created

• #537 More specific prefix in some cmake_parse_argument calls (backport #523) has been created for branch iron
• #538 More specific prefix in some cmake_parse_argument calls (backport #523) has been created for branch humble
• #539 More specific prefix in some cmake_parse_argument calls (backport #523) has been created for branch jazzy