Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid multiple calling compinit even if it could be in the first call. #87

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

iuhilnehc-ynos
Copy link

Signed-off-by: Chen Lihui lihui.chen@sony.com

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos
Copy link
Author

to fix ros2/ros2_documentation#2944

@iuhilnehc-ynos
Copy link
Author

close it as it has a potential issue if there defines a function named complete.

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos
Copy link
Author

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

@mjbogusz
Copy link

Cross-ref ros2/ros2cli#534

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

See ros2/ros2cli#750 for an approach that doesn't collide with a complete function... But I'm not sure whether it's 100% correct either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants