update uncrustify config to reflect google code style #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge this for now since there was no feedback. Any future feedback can be incorporated into the cfg file as we go. |
dirk-thomas
added a commit
that referenced
this pull request
Jul 7, 2014
update uncrustify config to reflect google code style
dhood
added a commit
that referenced
this pull request
Feb 1, 2017
* Add flake8 linter * Don't deal with flake8-import-order just yet * Debugging prints * Reinstate import order rule * Fix reporting bug by using the inner flake8 style guide * Fixup * Add comment on wrapper StyleGuide use * use flake8 v3 (#1) * Reorder package.xml * Get the filenames from the file checkers because input_file isn't called by flake8 anymore * Output count of all error types * Get flake8 to use the config file The current implementation of get_style_guide does not process the config file correctly. * Error when flake8 v2 found * Print errors like pep8 * remove __future__ imports * add schema to manifest files * Support flake8 v2 as well as v3 * Output checked files otherwise it's not present in xunit files for tests run directly with nose (not ament_cmake_flake8) * Prevent v2 imports from happening on systems with v3 * Flake8 replaces pep8+pyflakes
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
* Add flake8 linter * Don't deal with flake8-import-order just yet * Debugging prints * Reinstate import order rule * Fix reporting bug by using the inner flake8 style guide * Fixup * Add comment on wrapper StyleGuide use * use flake8 v3 (#1) * Reorder package.xml * Get the filenames from the file checkers because input_file isn't called by flake8 anymore * Output count of all error types * Get flake8 to use the config file The current implementation of get_style_guide does not process the config file correctly. * Error when flake8 v2 found * Print errors like pep8 * remove __future__ imports * add schema to manifest files * Support flake8 v2 as well as v3 * Output checked files otherwise it's not present in xunit files for tests run directly with nose (not ament_cmake_flake8) * Prevent v2 imports from happening on systems with v3 * Flake8 replaces pep8+pyflakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the uncrustify configuration with the code style from the Google document (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml).
@ament/owners Please consider trying it with some C++ code and if necessary commit patches to / provide pull request for this branch. You can either run
ament_uncrustifyto see the actual diff or use the option--reformatto update the files (which are hopefully under version control) in place.