Add custom config file support for clang-format #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
|
Using a file in the cwd is kind of opaque. You have to know that this feature exists in order to use it. I would suggest to instead add a command line option to the CLI as well as a keyword argument and global variable to the CMake API. |
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
|
Added suggested CMake changes |
dirk-thomas
reviewed
Jul 23, 2019
ament_cmake_clang_format/cmake/ament_cmake_clang_format_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
dirk-thomas
reviewed
Jul 23, 2019
ament_cmake_clang_format/cmake/ament_cmake_clang_format_lint_hook.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
dirk-thomas
reviewed
Jul 23, 2019
dirk-thomas
approved these changes
Jul 23, 2019
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
|
Looks like this introduced some linter failures on the nightly CI: @JShep1 can you please fix those up? Also, it's preferable if you run CI even for small changes like this before merging. Thanks! |
|
Btw, If you need help running the tests locally, or configuring CI so it's as quick as possible while still covering the change, let me know. |
|
Resolved in #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the
.clang-formatfile in theconfiguration/directory can be used. This update adds support for custom.clang-formatfiles placed in the directory from whichament_clang_formatis called.Signed-off-by: John Shepherd johnshepherd96@yahoo.com