Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error output, header out option, fix null error #163

Merged
merged 6 commits into from
Jul 29, 2019
Merged

Add error output, header out option, fix null error #163

merged 6 commits into from
Jul 29, 2019

Conversation

JShep1
Copy link
Contributor

@JShep1 JShep1 commented Jul 26, 2019 •
edited
Loading

  • Add error output to console.
  • Add option for user to specify non-system header error output
  • Fix bug with referencing report dictionary if no files were checked

Fixes #161

Signed-off-by: John Shepherd johnshepherd96@yahoo.com

@JShep1
Add error output, header out option, fix null error
4c33a3f 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1
Fix spacing around addition operators
35e91de 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1 JShep1 mentioned this pull request Jul 26, 2019
Closed
@JShep1
Add header flag to documentation
189fc10 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1 JShep1 requested a review from jacobperron July 26, 2019 17:58
@rotu
Copy link
Contributor

rotu commented Jul 26, 2019

I would add the -quiet option to clang-tidy. It does not suppress the output we're interested in but does suppress warnings about skipping system headers as well as the recommendation to pass the -system-headers argument (which ament_clang_tidy chockes on anyway).

@JShep1
Copy link
Contributor Author

JShep1 commented Jul 26, 2019

Sounds good, will add shortly, thanks for the recommendation

@JShep1
Add quiet option to ament_clang_tidy
b54e4ab 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1
Add header filter and system header option
c1dc68e 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1 JShep1 requested a review from jacobperron July 29, 2019 22:04
jacobperron
jacobperron approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ament_clang_tidy/ament_clang_tidy/main.py Outdated Show resolved Hide resolved
@JShep1
Alphabetized flag options
e14e7f4 
Signed-off-by: John Shepherd <johnshepherd96@yahoo.com>
@JShep1 JShep1 merged commit a9d01e2 into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the jshep1/add_tidy_out branch July 29, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ament_clang_tidy doesn't show errors, thinks all headers are system headers
3 participants
@JShep1 @rotu @jacobperron