Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom config file support for flake8 #331

Merged

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Oct 20, 2021

Added custom config file support for flake8 in the same way as #153 and #159. (They are fixed in #180)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

@audrow Hello. Could you review this PR, please? 🙏

@nuclearsandwich
Copy link
Contributor

I've pushed a copy of this branch as nuclearsandwich/support-flake8-config-file to facilitate an easier CI run.
I am on the road but plan to run CI that verifies this change does not break the default config behavior (it certainly looks like it shouldn't).

@nuclearsandwich nuclearsandwich self-assigned this Nov 3, 2021
@nuclearsandwich
Copy link
Contributor

CI running linter tests only scoped to ament_flake8's dependents and dependencies

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich merged commit 226f3d4 into ament:master Nov 4, 2021
@nuclearsandwich
Copy link
Contributor

Thank you for the patch @kenji-miyake!

@kenji-miyake kenji-miyake deleted the support-flake8-config-file branch January 17, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants