Changes to make ament_flake8 work with v6+ #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
|
Hi @mjcarroll, I hope the dependency of |
|
@tylerjw To take a look as well. |
clalancette
requested changes
Nov 30, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Dec 6, 2023
|
CI:
|
|
@clalancette Thanks for implementing these changes. Are we planning to add this change to other versions? I'm most concerned about the Humble version. |
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit fc02432) # Conflicts: # ament_flake8/ament_flake8/main.py
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit fc02432)
clalancette
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit fc02432) Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
|
@Mergifyio backport iron |
✅ Backports have been created
|
clalancette
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit fc02432)
clalancette
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit fc02432) Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
wuisky
pushed a commit
to wuisky/ament_lint
that referenced
this pull request
Feb 7, 2024
* Changes to make ament_flake8 work with v6+ * Correct make_file_checker_manager call * Fix compatibility with flake8 5. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: WU MENGHUNG <wu.menghung@jp.panasonic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_preliminary_options_and_argsandparse_preliminary_optionshave both been removed in favor ofparse_argsin this commit: PyCQA/flake8@0d667a7(No corresponding PR as far as I can tell).
This is the minimal set of changes to get build/test passing on flake8 v6