Fix file exclusion behavior in ament_cppcheck and ament_cpplint #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
|
CI run with build
|
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Rerunning CI after fix
|
aprotyas
added a commit
to aprotyas/ament_lint
that referenced
this pull request
Oct 17, 2021
This commit fixes the faulty file exclusion behavior reported in ament#326. Specifically, it walks down the path where `ament_copyright` has been invoked to build a map of files to be tested, respecting the exclusion list by globbing and matching against files in the tree. Changes inspired by ament#299. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
kenji-miyake
pushed a commit
to kenji-miyake/ament_lint
that referenced
this pull request
Oct 20, 2021
…t#299) * fix exclude behavior in ament_cppcheck and ament_cpplint Signed-off-by: Miaofei <miaofei@amazon.com> * fix flake8 errors Signed-off-by: Miaofei <miaofei@amazon.com> * add missing realpath() conversion Signed-off-by: Miaofei <miaofei@amazon.com>
audrow
pushed a commit
that referenced
this pull request
Nov 4, 2021
* [ament_copyright] Fix file exclusion behavior This commit fixes the faulty file exclusion behavior reported in #326. Specifically, the exclusion list is matched against traversed files in the `crawler` module. Changes inspired by #299. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu> * Update excluded file path in copyright tests Since file names are not indiscriminately matched throughout the search tree anymore, the excluded files listed in the copyright tests need to be updated relative to the root of the package. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu> * Add test cases to check exclusion behavior Specifically, these tests check for: - Incorrect exclusion of single filenames. - Correct exclusion of relatively/absolutely addressed filenames. - Correct exclusion of wildcarded paths. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu> * Add unit tests for crawler module These unit tests make sure both search and exclusion behaviors are correctly demonstrated by the `ament_copyright.crawler` module. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
This pull request fixes the issue described at #234 (comment) and possibly replaces #238.
This pull request also makes the behavior between
ament_cppcheckandament_cpplintconsistent.