Minor code cleanups in tf2 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This is more efficient. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It just makes more sense. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This should improve compile times for downstream projects. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
aprotyas
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
LGTM. On a similar note, what about common linter (and cppcheck) tests on this package?
I noticed this comment in the CMakeLists.txt file:
# TODO(clalancette) enable linters once https://github.com/ament/ament_lint/pull/238 landsIt looks like ament/ament_lint#238 has been closed and replaced with the (now merged) ament/ament_lint#299 though. Thoughts? I could put this in a separate PR akin to #464.
Oh, I didn't even check. That would be great @aprotyas ! |
|
CI is green, and this has an approval. I'm going to go ahead and merge, thanks for the review! |
aprotyas
added a commit
that referenced
this pull request
Dec 18, 2021
As discussed in #467: - Enables a subset of relevant linter tests from `ament_lint_common` in `tf2`. - Excludes LinearMath headers (include/tf2/LinearMath) from being linted. - Fixes line-length formatting issues in a few source files, so that there are no lint failures in the current state. Note that individual linters had to be invoked rather than use `ament_lint_auto` because the LinearMath headers should not have linters run on them - see #258 (comment) for more information - and because `ament_lint_auto` does not provide a general way of providing file exclusion lists. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches aims to do a bit of minor cleanup on the code in tf2. There should be no functional change with this in place. The changes include:
foo.empty()instead offoo == ""std::make_sharedwhere possible