Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Scripts to PATH on Windows #57

Merged
merged 2 commits into from
Aug 17, 2017
Merged

add Scripts to PATH on Windows #57

merged 2 commits into from
Aug 17, 2017

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Aug 17, 2017

Work around different default installation path for Python scripts on Windows, see ament/ament_tools#156 (comment).

Before: Build Status
After: Build Status (much further - but not all the way yet...)

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Aug 17, 2017
@dirk-thomas dirk-thomas self-assigned this Aug 17, 2017
@dirk-thomas
Copy link
Contributor Author

Not to a big surprise this pushed us over the max length for the PATH environment variable again. Therefore I added a second commit which only adds paths when they actually exist: Build Status

@mikaelarguedas
Copy link
Contributor

... env var max length on windows ... How do we plan to handle thati n the future? just recommend to users to never "build in isolation" (aka install in isolation) on windows ?

@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Aug 17, 2017

... env var max length on windows ... How do we plan to handle thati n the future?

Someone has to take on the pleasure task to write PowerShell scripts rather than Batch scripts. It feels to me that you want to volunteer for this glorious task 😜

@mikaelarguedas
Copy link
Contributor

Someone has to take on the pleasure task to write PowerShell scripts rather than Batch scripts. It feels to me that you want to volunteer for this glorious task

Oh I didn't know it was a limitation of batch and not the system, looks like you know a lot more than me about this 😉

@dirk-thomas
Copy link
Contributor Author

Oh I didn't know it was a limitation of batch and not the system, looks like you know a lot more than me about this 😉

Oh, thank you 😄 I am happy to share the knowledge if anybody would like to work on it... 😇

@dirk-thomas dirk-thomas mentioned this pull request Aug 17, 2017
@dirk-thomas dirk-thomas merged commit 30ec27e into master Aug 17, 2017
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Aug 17, 2017
@dirk-thomas dirk-thomas deleted the windows_path_scripts branch August 17, 2017 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants