Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

need to source build dependencies for ament-python build type #109

Closed
mikaelarguedas opened this issue Oct 17, 2016 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@mikaelarguedas
Copy link
Contributor

No description provided.

@dirk-thomas
Copy link
Contributor

This seems to be already the case: see

prefix = self._get_command_prefix('install', context)

Can you please provide a reproducible example.

@dirk-thomas dirk-thomas added the more-information-needed Further information is required label Jun 19, 2017
@dirk-thomas
Copy link
Contributor

Might it be related to the introspection of the setup file before the actual build is happening? Triggered by this line

args = get_setup_arguments(os.path.join(context.source_space, 'setup.py'))

@mikaelarguedas
Copy link
Contributor Author

TBH that was a long time ago, I don't really remember. I think that I needed to source manually rclpy otherwise I could not build the executables of ros2/examples#127 (because setup.py was calling some rclpy functions)

@dirk-thomas dirk-thomas self-assigned this Jun 20, 2017
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) and removed more-information-needed Further information is required labels Jun 20, 2017
@clalancette
Copy link
Contributor

@mikaelarguedas Since the upstream PR was merged, can this be closed?

@wjwwood
Copy link
Contributor

wjwwood commented Jun 23, 2017

@dirk-thomas when you get a chance, can this be merged? (@mikaelarguedas said to ask you)

@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants