Avoiding empty blocks

[mrchass]

Hello!
It leads to syntax errors if there are empty blocks '{ }' in graphql requests. There will be an empty block in your request if you create a mutation with no response defined. In this case you have one property (mutation's name) with several arguments but no children.
For example:
An empty class defining the mutation request:
@GraphQLProperty(name="myMutation", arguments={ @GraphQLArgument(name="myArgument1"), @GraphQLArgument(name="myArgument2") }) public class MyMutationModel {}

Creating the request:
GraphQLRequestEntity requestEntity = GraphQLRequestEntity.Builder() .url("http://graphql.example.com/graphql"). .arguments(new Arguments("myMutation", new Argument("myArgument1", "value1"), new Argument("myArgument2", "value2"))) .request(MyMutationModel.class) .build(); GraphQLResponseEntity<Boolean> responseEntity = graphQLTemplate.query(requestEntity, Boolean.class);

The created request would look like this:
mutation {myMutation(myArgument1:"value1", myArgument2:"value2") { } }

But a vlid request has to look like this:

mutation {myMutation(myArgument1:"value1", myArgument2:"value2") }

I think it would be a good idea to prevent empty blocks from being created in general. Because Property.class' member variable "children" is an empty map, at least in this case, it is very likely that empty blocks will be created.

My little modification would fix this behaviour. Or is there another way to deal with requests like this?

Cheers,
Christian

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Pull Request Test Coverage Report for Build 43

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.71%

---

Totals
Change from base Build 28:	0.0%
Covered Lines:	459
Relevant Lines:	465

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 43

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.71%

---

Totals
Change from base Build 28:	0.0%
Covered Lines:	459
Relevant Lines:	465

---

💛 - Coveralls

[chemdrew]

Looks great, thanks for this contribution!

[mrchass]

@chemdrew : Thank you for accepting this change! Could you tell me, when the next verson will be released and will be available in the repository?
Thanks, Christian

[chemdrew]

@mrchass just released v0.1.2 the fix should be available now!