This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat(GraphQLArgument): introduce optional arguments #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend GraphQLArgument annotation class with field "optional" (default to false for backward compatibility) Clean "null" stings in valueOf handling of argument values, treat as null reference Handle optional values in Property query message generation
Remove redundant "null"-string checks now covered in value parsing Increase test coverage above jacoco threshold (88->100%)
Pull Request Test Coverage Report for Build 81
💛 - Coveralls |
Pull Request Test Coverage Report for Build 82
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend GraphQLArgument annotation class with field "optional" (default to false for backward compatibility)
Proposal for handling of API with mutually exclusive arguments using annotations. See test cases in GraphQLRequestEntityTest.
Closes #56