This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(errorHandler): application errors would result in a 200 response #1243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set HTTP status code to 500 in application error handler
Motivation and Context
Application errors were causing HTTP 200 responses
How Has This Been Tested?
Triggered an application error caused by bug fixed in #1242 validated that HTTP status of error page was 200 before change and 500 after
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Correct HTTP status of application errors