Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(env): don't require ONE_ENABLE_POST_TO_MODULE_ROUTES to be set #738

Merged
merged 1 commit into from
May 5, 2022

Conversation

Matthew-Mallimo
Copy link
Member

Description

ONE_ENABLE_POST_TO_MODULE_ROUTES was defaulted to false.
ONE_MAX_POST_REQUEST_PAYLOAD required ONE_ENABLE_POST_TO_MODULE_ROUTES to be true, or else it threw an error.

So on startup of one-app, it would fail to start unless you set ONE_ENABLE_POST_TO_MODULE_ROUTES to true.

ALSO

ONE_ENABLE_POST_TO_MODULE_ROUTES used to be true as long as any value was set. This was changed to require it to be either true or false, which is a breaking change. This PR reverts that.

Motivation and Context

Broke one-app

How Has This Been Tested?

unit

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

📊 Bundle Size Report

file name size on disk gzip
app.js 314.7KB 93.4KB
runtime.js 15.6KB 5.5KB
vendors.js 148.2KB 47.6KB
app~vendors.js 431.2KB 112.6KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 335.6KB 98.3KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 211KB 59.7KB
legacy/app~vendors.js 453KB 118.3KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against 29ed9f9

@Matthew-Mallimo Matthew-Mallimo merged commit e7becf0 into main May 5, 2022
@Matthew-Mallimo Matthew-Mallimo deleted the fix/envVars branch May 5, 2022 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants