This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(env): don't require ONE_ENABLE_POST_TO_MODULE_ROUTES to be set #738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ONE_ENABLE_POST_TO_MODULE_ROUTES was defaulted to
false
.ONE_MAX_POST_REQUEST_PAYLOAD required ONE_ENABLE_POST_TO_MODULE_ROUTES to be true, or else it threw an error.
So on startup of one-app, it would fail to start unless you set ONE_ENABLE_POST_TO_MODULE_ROUTES to true.
ALSO
ONE_ENABLE_POST_TO_MODULE_ROUTES used to be true as long as any value was set. This was changed to require it to be either
true
orfalse
, which is a breaking change. This PR reverts that.Motivation and Context
Broke one-app
How Has This Been Tested?
unit
Types of Changes
Checklist:
What is the Impact to Developers Using One App?