Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(cdnCache): make clear cache message generic #1248

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jan 22, 2024

Description

Changes the message from:

LOG: **************************************************************
LOG: CACHE INFORMATION
LOG: File size of .one-app-module-cache: 1.00 MB
LOG: To delete cache, please run
LOG:     rm  /home/node/.one-app/.one-app-module-cache
LOG: **************************************************************

to:

LOG: **************************************************************
LOG: CACHE INFORMATION
LOG: File size of .one-app-module-cache: 1.00 MB
LOG: To clear the cache, please delete this file:
LOG:     ~/.one-app/.one-app-module-cache
LOG: **************************************************************

This is trying to be generic enough to work across Mac and Windows and standalone and Docker, but it's a difficult problem.

Motivation and Context

Fixes #1244

Namely, running rm /home/node/.one-app/.one-app-module-cache will not delete the cache when running One App in Docker.

How Has This Been Tested?

Added unit test.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

More accurate instructions.

@smackfu smackfu requested review from a team as code owners January 22, 2024 17:35
@smackfu smackfu requested a review from a team January 23, 2024 14:40
@smackfu smackfu enabled auto-merge (squash) January 23, 2024 15:06
@smackfu smackfu merged commit cac2e81 into americanexpress:main Jan 23, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong directions to delete one-app-dev-cdn cache when run in docker
3 participants