Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

test(integration): use otel file exporter instead of logging exporter #1325

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Use file exporter for logs in otel collector during integration tests & upload logs and traces as artifacts

Motivation and Context

Better debuggability of integration tests on GH

How Has This Been Tested?

This PR

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

N/A

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Size Change: 0 B

Total Size: 719 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 171 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@10xLaCroixDrinker 10xLaCroixDrinker force-pushed the feature/send-prod-sample-logs-to-file branch 7 times, most recently from d9d5c9e to 3dea378 Compare March 13, 2024 20:54
@10xLaCroixDrinker 10xLaCroixDrinker force-pushed the feature/send-prod-sample-logs-to-file branch from 3dea378 to 96024df Compare March 13, 2024 21:11
@10xLaCroixDrinker 10xLaCroixDrinker marked this pull request as ready for review March 13, 2024 21:28
@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners March 13, 2024 21:28
@@ -106,10 +106,11 @@ services:
# sleep 5s to make sure set up is completed prior to opening up chrome
entrypoint: bash -c '/opt/bin/entry_point.sh & sleep 5s && chromium --ignore-certificate-errors --no-first-run --autofill-server-url https://one-app:8443/success'
otel-collector:
image: 'otel/opentelemetry-collector:0.95.0'
image: 'otel/opentelemetry-collector-contrib-dev:9355dce6c04b89e76ef80e043709b5cc40c0de23'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The append feature is unreleased, so we can pin to this nightly for now. Otherwise the logs are cleared each time the container restarts.

@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) March 14, 2024 18:10
@10xLaCroixDrinker 10xLaCroixDrinker merged commit af987a1 into main Mar 14, 2024
9 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/send-prod-sample-logs-to-file branch March 14, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants