Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

One App release process #90

Merged
merged 27 commits into from
Apr 8, 2020
Merged

One App release process #90

merged 27 commits into from
Apr 8, 2020

Conversation

nellyk
Copy link
Contributor

@nellyk nellyk commented Apr 2, 2020

This outlines the process for releasing One App and adds the functionality using GitHub actions
Please merge this once this is merged #82

Description

The process is documented in Release.md
Please review the file for steps on getting a released started.

An automated pull request is raised every Wednesday and once merged, a tag is created automatically. This kicks off the build of the development and production images which are released to the docker hub. Statics are published to npm added by @infoxicator as part of #82

The last step is to update the release notes and tag it to the release.

Motivation and Context

This allows us to create a manual or automatic releases of One App. Enabling One App users to be able to access One App images to create experiences using it.

How Has This Been Tested?

Yes please review this

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

This would allow docker images to be published for One App developers to use to create experiences

@nellyk nellyk requested review from a team as code owners April 2, 2020 21:08
@oneamexbot
Copy link
Contributor

oneamexbot commented Apr 2, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 405.9KB 106KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 412KB 107.6KB

Generated by 🚫 dangerJS against 43fb28b

scripts/run-integration-tests.travis.sh Outdated Show resolved Hide resolved
.github/workflows/greetings.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@infoxicator infoxicator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the travis script

scripts/run-integration-tests.travis.sh Outdated Show resolved Hide resolved
@mtomcal
Copy link
Contributor

mtomcal commented Apr 6, 2020

Do we have in place a way to make sure >= 1 One Amex Admins need to approve the release PR?

mtomcal
mtomcal previously approved these changes Apr 6, 2020
.github/workflows/docker_release.yml Show resolved Hide resolved
.github/workflows/pull_request_release.yml Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
scripts/run-integration-tests.travis.sh Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
nellyk and others added 6 commits April 7, 2020 11:49
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
nellyk and others added 4 commits April 8, 2020 11:11
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Mike Tobia <Francois-Esquire@users.noreply.github.com>
infoxicator
infoxicator previously approved these changes Apr 8, 2020
.github/workflows/tagging.yml Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
@nellyk nellyk dismissed stale reviews from infoxicator and Francois-Esquire via 4b4e48c April 8, 2020 17:28
Copy link
Contributor

@infoxicator infoxicator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @nellyk ! 👍

@nellyk
Copy link
Contributor Author

nellyk commented Apr 8, 2020

Well done @nellyk ! 👍

Thank you so much for your help @infoxicator wouldn't be able to get here without you support

@JAdshead JAdshead self-requested a review April 8, 2020 17:50
Copy link
Contributor

@mtomcal mtomcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @nellyk!

Copy link
Contributor

@JAdshead JAdshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are there

- name: One App release
id: vars
run: |
NODE_ENV=development npm ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do?

env:
  NODE_ENV: development

Not a blocker, but just curious.

@JAdshead JAdshead merged commit 72ea38b into master Apr 8, 2020
@JAdshead JAdshead deleted the feat/one-app-release branch April 8, 2020 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants