-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
📊 Bundle Size Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the travis script
…ress/one-app into feat/one-app-release
Do we have in place a way to make sure >= 1 One Amex Admins need to approve the release PR? |
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jimmy King <jimmy.king@aexp.com>
…ress/one-app into feat/one-app-release
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Mike Tobia <Francois-Esquire@users.noreply.github.com>
4b4e48c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @nellyk ! 👍
Thank you so much for your help @infoxicator wouldn't be able to get here without you support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @nellyk!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are there
- name: One App release | ||
id: vars | ||
run: | | ||
NODE_ENV=development npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do?
env:
NODE_ENV: development
Not a blocker, but just curious.
This outlines the process for releasing One App and adds the functionality using GitHub actions
Please merge this once this is merged #82
Description
The process is documented in Release.md
Please review the file for steps on getting a released started.
An automated pull request is raised every Wednesday and once merged, a tag is created automatically. This kicks off the build of the development and production images which are released to the docker hub. Statics are published to npm added by @infoxicator as part of #82
The last step is to update the release notes and tag it to the release.
Motivation and Context
This allows us to create a manual or automatic releases of One App. Enabling One App users to be able to access One App images to create experiences using it.
How Has This Been Tested?
Yes please review this
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
This would allow docker images to be published for One App developers to use to create experiences