Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(workflows): on-pr-and-trunk_one-app-unit-and-lint-tests exclude 18.16.0 #994

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented May 9, 2023

Description

test with Node.js 18.x but before 18.16.0
This will need to be reverted when the bug is resolved and released in a new version.

Motivation and Context

unit tests are affected by a bug: nodejs/node#47563

How Has This Been Tested?

GitHub workflow, so can't run locally :S

but did run the semver syntax through https://semver.npmjs.com/ with lodash via ^4 < 4.17

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

PRs should have less false-positives.

@github-actions github-actions bot added the chore label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Size Change: 0 B

Total Size: 687 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 389 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 120 kB

compressed-size-action

@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [16.x, "^18 < 18.16"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was looking into creating this PR.

@PixnBits PixnBits marked this pull request as ready for review May 9, 2023 22:50
@PixnBits PixnBits requested review from a team as code owners May 9, 2023 22:50
Copy link
Contributor

@JAdshead JAdshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated branch permissions for this change. that will also need to be reverted when fix is released

@JAdshead JAdshead enabled auto-merge (squash) May 10, 2023 16:05
@JAdshead JAdshead merged commit cec9c06 into main May 12, 2023
@JAdshead JAdshead deleted the chore/on-pr-and-trunk_one-app-unit-and-lint-tests_18.16.0-unit-tests branch May 12, 2023 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants