Fix test not able to run #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 23, 2017 16:46
jeffbdavenport
commented
Apr 23, 2017
| router.exists?("/index", "GETSS") | ||
| end | ||
| end | ||
| # it "return true if route path exists" do |
There was a problem hiding this comment.
the #exists method doesn't exist, not sure why these specs were created
|
@jeffreydvp, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I made a bunch of changes and was finally able to get tests to run, however there are 8 test failing that I'm not quite sure what the best steps are to resolve them.
This PR changes the mime repository to my fork to fix some of the bugs preventing tests being able to run.
Make sure you run this before troubleshooting
crystal deps update mimeI am willing to looking into the failing tests if someone can shed some light on the best steps to take to resolve them