Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export failure #111

Closed
icefoxen opened this issue Apr 25, 2019 · 2 comments
Closed

Re-export failure #111

icefoxen opened this issue Apr 25, 2019 · 2 comments

Comments

@icefoxen
Copy link
Contributor

The SimpleGraphicsPipeline trait has a method that returns failure::Error: https://docs.rs/rendy/0.1.1/rendy/graph/render/trait.SimpleGraphicsPipeline.html#tymethod.build

This seems unnecessary since it looks like it could be easy to replace with an associated Error type, but if we want to use failure we should at least re-export it similar to how gfx_hal is re-exported. That way if users have a version clash somehow, they at least have a convenient reference to the version of failure we are using. This honestly isn't likely, given how stable failure is, but I find it to be a useful policy.
@zakarumych
Copy link
Member

Associated error type would do, but different error types from different pipelines still have to be merged.
But reexporting looks like a good idea.

@icefoxen icefoxen mentioned this issue Apr 28, 2019
Merged
zakarumych pushed a commit to zakarumych/rendy that referenced this issue May 18, 2019
Cleanup Cargo.toml files
a4d99ce 
Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes amethyst#39 amethyst#111
zakarumych pushed a commit to zakarumych/rendy that referenced this issue May 18, 2019
Cleanup Cargo.toml files
d1bd512 
Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes amethyst#39 amethyst#111
zakarumych pushed a commit to zakarumych/rendy that referenced this issue May 18, 2019
Cleanup Cargo.toml files
a7eb5e6 
Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes amethyst#39 amethyst#111
@zakarumych zakarumych mentioned this issue May 18, 2019
Merged
bors bot added a commit that referenced this issue May 20, 2019
@bors
Merge #133
dafba9d 
133: Cleanup Cargo.toml files r=Frizi a=omni-viral

Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes #39 #111

Those changes are mostly code move, renames etc.

P.S. Sorry for making this all in one PR

Co-authored-by: Zakarum <scareaangel@gmail.com>
bors bot added a commit that referenced this issue May 20, 2019
@bors
Merge #133
da8de92 
133: Cleanup Cargo.toml files r=Frizi a=omni-viral

Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes #39 #111

Those changes are mostly code move, renames etc.

P.S. Sorry for making this all in one PR

Co-authored-by: Zakarum <scareaangel@gmail.com>
bors bot added a commit that referenced this issue May 20, 2019
@bors
Merge #133
80c1ca8 
133: Cleanup Cargo.toml files r=Frizi a=omni-viral

Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes #39 #111

Those changes are mostly code move, renames etc.

P.S. Sorry for making this all in one PR

Co-authored-by: Zakarum <scareaangel@gmail.com>
bors bot added a commit that referenced this issue May 20, 2019
@bors
Merge #133
be3f163 
133: Cleanup Cargo.toml files r=Frizi a=omni-viral

Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes #39 #111

Those changes are mostly code move, renames etc.

P.S. Sorry for making this all in one PR

Co-authored-by: Zakarum <scareaangel@gmail.com>
bors bot added a commit that referenced this issue May 20, 2019
@bors @fu5ha
Merge #127 #133
e9110f4 
127: add specialization constant configuration r=termhn a=termhn



133: Cleanup Cargo.toml files r=Frizi a=omni-viral

Remove requirement for enabling features transitively to all crates. All common features now
relayed through rendy-util.
Make winit optional.
Refactor backend matching macros.
cargo fmt run.
Fixes #39 #111

Those changes are mostly code move, renames etc.

P.S. Sorry for making this all in one PR

Co-authored-by: Gray Olson <gray@grayolson.com>
Co-authored-by: Zakarum <scareaangel@gmail.com>
@malobre
Copy link
Contributor

malobre commented Oct 19, 2019

Since #211 was merged maybe this should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icefoxen @malobre @zakarumych