-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove derivative from rendy #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 6 6
Lines 169 169
=======================================
Hits 148 148
Misses 21 21
Continue to review full report at Codecov.
|
I like the idea, but before we commit to writing impls manually i'd like to see actual numbers. Can you measure the build times from before and after this change? |
Sure, and as it turns out the times are pretty much the exact same as it seems, regarding just building the rendy crates without the dependencies I got |
In that case I would prefer to get rid of |
Ye figured, definitely the smarter choice to stick with derivative then for the time being. Will try to see what removing failure will do and if it improves the times or not, depending on that I'll do a PR or comment in issue #203 with my findings. |
Okay, thank you for doing that @Veykril :) |
Removes the derivative dependency from crates that are using it, as mentioned in #203, replacing it with manual implementations of the corresponding traits.