Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amethyst CLI rewrite #39

Merged
merged 5 commits into from
Oct 24, 2017
Merged

Amethyst CLI rewrite #39

merged 5 commits into from
Oct 24, 2017

Conversation

torkleyy
Copy link
Member

No description provided.

Copy link
Member

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I'm not sure I understand what the build script is doing.

@torkleyy
Copy link
Member Author

@Xaeroxe So basically there is a template folder. It contains an index.ron file. This file lists all the files we actually want in the final template. And the build script just includes these listed files into the source code (_template_files.rs which is included by src/new.rs).

@Xaeroxe
Copy link
Member

Xaeroxe commented Oct 24, 2017

Oh huh, that's an interesting way of doing that. Definitely saves a lot of work though :D Can you add that explanation as a comment at the top of the build script? Then I think we'll be ready to merge.

@Xaeroxe
Copy link
Member

Xaeroxe commented Oct 24, 2017

Tested locally, works great, thanks a ton @torkleyy

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 24, 2017

🔒 Permission denied

Existing reviewers: click here to make Xaeroxe a reviewer

@Xaeroxe
Copy link
Member

Xaeroxe commented Oct 24, 2017

Uh that's awkward. Ok well here goes.

@Xaeroxe Xaeroxe merged commit 5129207 into amethyst:master Oct 24, 2017
@torkleyy torkleyy deleted the rewrite branch October 24, 2017 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants