-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_bias_force_comp #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good, even though I didn't check in details the calculation. I trust you (and the tests 😄).
The only minor comment is the value of the gravity acceleration. It would maybe useful to store it somewhere (like we did in blf). I saw you added a rw property, maybe the best pattern here since is something that does not change after setting it, is defining it in the constructor with a default value, similarly to this.
Thanks @diegoferigo! :D
Yes, it makes sense! I'll address this point in a separate PR.
I wanted to give the possibility to change the value also after instantiating the class, but, thinking about it, maybe its better to define it just in the constructor. Changing it! |
I use this PR also to add the copyright header. Merging! |
This PR add the computation of the bias force of the floating-base dynamics equation.