Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_bias_force_comp #2

Merged
merged 13 commits into from
Jun 9, 2021
Merged

add_bias_force_comp #2

merged 13 commits into from
Jun 9, 2021

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Jun 9, 2021

This PR add the computation of the bias force of the floating-base dynamics equation.

@Giulero Giulero marked this pull request as ready for review June 9, 2021 11:22
@Giulero Giulero self-assigned this Jun 9, 2021
@Giulero Giulero added the enhancement New feature or request label Jun 9, 2021
@Giulero Giulero requested a review from diegoferigo June 9, 2021 13:15
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, even though I didn't check in details the calculation. I trust you (and the tests 😄).

The only minor comment is the value of the gravity acceleration. It would maybe useful to store it somewhere (like we did in blf). I saw you added a rw property, maybe the best pattern here since is something that does not change after setting it, is defining it in the constructor with a default value, similarly to this.

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 9, 2021

Thanks @diegoferigo! :D

It would maybe useful to store it somewhere (like we did in blf)

Yes, it makes sense! I'll address this point in a separate PR.

is defining it in the constructor with a default value

I wanted to give the possibility to change the value also after instantiating the class, but, thinking about it, maybe its better to define it just in the constructor. Changing it!

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 9, 2021

I use this PR also to add the copyright header. Merging!

@Giulero Giulero merged commit 54144e5 into main Jun 9, 2021
@Giulero Giulero deleted the add_bias_force_comp branch June 9, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants