Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for computing the bias acceleration of the center of mass #161

Merged
merged 3 commits into from
May 28, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented May 27, 2024

Similarly to #127, this PR computes the bias linear acceleration of the CoM. It provides the $\dot{J}^l_{\text{CMM}} \boldsymbol{\nu}$ contribution to the CoM linear acceleration that is not dependent on $\dot{\boldsymbol{\nu}}$. In inertial-fixed and mixed representation, we have that $G = G[W]$, while in body-fixed representation, we have that $G = G[B]$.


馃摎 Documentation preview 馃摎: https://jaxsim--161.org.readthedocs.build//161/

@diegoferigo diegoferigo self-assigned this May 27, 2024
@diegoferigo
Copy link
Member Author

I've narrowed down the failures in CI. The new test is currently failing when:

  • The model is floating base.
  • The velocity representation is Mixed.
  • Then base angular velocity $\boldsymbol{\omega}_{W,B}$ is not zero.

@diegoferigo diegoferigo force-pushed the com_bias_acceleration branch 4 times, most recently from ef74e1f to 14548db Compare May 28, 2024 10:20
@diegoferigo diegoferigo marked this pull request as ready for review May 28, 2024 10:27
@diegoferigo
Copy link
Member Author

diegoferigo commented May 28, 2024

After chatting with @traversaro, we realized that the previous logic was setting to zero the wrong $\dot{\boldsymbol{\nu}}$. The solution is to compute the bias link acceleration in the active representation (implemented in #127, that internally sets to zero the right $\dot{\boldsymbol{\nu}}$), and then convert back these accelerations to body-fixed representation to obtain the bias ${}_G \dot{\mathbf{h}}$.

I believe that we can unify somehow the complicated logic used in the functions to compute the bias accelerations of links and CoM, but this can be done in another PR. I want to move this forward since it is finally working fine.

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Diego, LGTM!

@diegoferigo diegoferigo merged commit a8a89b7 into main May 28, 2024
29 checks passed
@diegoferigo diegoferigo deleted the com_bias_acceleration branch May 28, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants