Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAXsim Notebook for Parallel Simulation #65

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

flferretti
Copy link
Collaborator

This PR will add a notebook with pixi support as a guide to write parallel simulation with JAXsim.

In particular, this example will concern the simulation of multiple free falling spheres, with different initial pose.

The idea is to avoid the free-fall motion visualization for this example, but rather to plot the height time serie for each sphere, as I don't know if MuJoCo supports multiple models rendering.

@flferretti flferretti self-assigned this Jan 15, 2024
@flferretti flferretti marked this pull request as ready for review January 15, 2024 16:37
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with few comments:

  • Maybe it's worth mentioning that parallel simulations are independent from each other. Adding a pose displacement is just useful to visualize a parallel simulation in a single visualizer instance without having overlapping models.
  • Can you check if the usage of mutable() is necessary? With the new OOP decorators, the mutable methods should already take care of enabling the mutability.
  • Probably is also worth specifying that step_over_horizon is useful only in the open-loop case. It can be used also in a closed-loop case, but it is much more complicated. At least in the beginning, using the regular step might be preferred.

@flferretti
Copy link
Collaborator Author

Thanks @diegoferigo, solved in daa5a9e and 2598d24. Merging

@flferretti flferretti merged commit d329544 into ami-iit:main Jan 15, 2024
3 checks passed
@flferretti flferretti deleted the example/parallel branch February 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants