Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not overwrite already specified Doxygen options #178

Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: do not overwrite already specified Doxygen options #178

merged 1 commit into from
Dec 21, 2022

Conversation

Subtixx
Copy link
Contributor

@Subtixx Subtixx commented Dec 21, 2022

Check if the settings we set are already set by the user, and if so don't overwrite them.

This fixes the just opened issue #177

Check if the settings we set are already set by the user, and if so don't overwrite them.
Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@Subtixx
Copy link
Contributor Author

Subtixx commented Dec 21, 2022

🤣 The failing windows test is doxygen again.. 🤣

@aminya
Copy link
Owner

aminya commented Dec 21, 2022

Haha. I think I fixed the download issue by having a retry mechanism in setup-cpp.
aminya/setup-cpp#155

@aminya aminya merged commit 399e272 into aminya:main Dec 21, 2022
@aminya aminya mentioned this pull request Dec 21, 2022
@aminya aminya changed the title Update Doxygen.cmake - Fixes #177 fix: do not overwrite already specified Doxygen options Dec 21, 2022
@Subtixx Subtixx deleted the Subtixx-patch-doxygen-overwrite-settings branch December 22, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants