Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate.py bugs #166

Closed
nschneid opened this issue Oct 15, 2023 · 1 comment
Closed

validate.py bugs #166

nschneid opened this issue Oct 15, 2023 · 1 comment

Comments

@nschneid
Copy link
Contributor

UniversalDependencies/UD_English-EWT@bcc83a4 updates neaten.py to fix a couple of issues inherited from validate.py:

if func == "auxpass" and lemma != "be" and lemma != "get":

  • checks for auxpass instead of aux:pass

be_funcs = ["cop", "aux", "root", "csubj", "auxpass", "rcmod", "ccomp", "advcl", "conj","xcomp","parataxis","vmod","pcomp"]
if lemma == "be" and func not in be_funcs:
if not parent_lemma == "that" and func == "fixed": # Exception for 'that is' as mwe
print("WARN: invalid dependency of lemma 'be' > " + func + inname)

  • has functions from Stanford Dependencies
  • will never be triggered in practice because not on line 790 scopes only over first conjunct
@amir-zeldes
Copy link
Owner

Fixed, thanks for catching!

amir-zeldes added a commit that referenced this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants