-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve JSON keys order #2970
Comments
Interesting ask! I agree JSON order matters. I am not actually sorting it in Dozzle. Looks like Go is doing it as described in golang/go#27179 There is a couple of solutions suggested there. I am not all too sure if they will work. But seems like the issue is converting JSON --> map --> back to JSON. |
So I used I haven't looked at all the details and what other regression issues maybe introduced. Can you test using |
Sure, Amir! Many thanks for the quick implementation! It seems to work on my site too! I'll check it more thoroughly later. Nevertheless, the info/warn/error colored bullets have disappeared. |
Hmm good catch. I think I know why. Do a little more testing and see what else could have broken. |
928c170 should fix it. Pull again. |
It did the trick! Great job, Amir! I already use it, and if I find something else I'll come back, but I don't think so 🙌 |
If you can do a little more testing, I can merge. |
So far so good, Amir! I think we can consider this as implemented! Many thanks again for the speed of light commits 🙇♀️ |
Will release a patch tomorrow. Working on swarm support so v7 will be coming out soon. |
Great news, Amir! Thank you very much for your efforts and contributions to the open source and Docker community 🙏 |
Is your feature request related to a problem? Please describe.
Good morning Amir and thank you again very much for this awesome tool! The JSON keys in the logs are always sorted alphabetically.
Describe the solution you'd like
I was wondering if there's a way to keep their order as is. Sometimes, the existing order is more intuitive as the alphabetical one.
Describe alternatives you've considered
I think there isn't an option for this. I couldn't also find where in the code the keys are sorted.
Additional context
Edit: An example is that the following
is displayed in Dozzle as
The text was updated successfully, but these errors were encountered: