Adds tests and uses filterName instead.
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling in Source
amir20
commented
Jul 22, 2019
| ### Building | ||
| To Build and test locally: | ||
|
|
||
| 1. Install NodeJs. |
amir20
commented
Jul 22, 2019
| ContainerLogs(context.Context, string, int) (<-chan string, <-chan error) | ||
| Events(context.Context) (<-chan events.Message, <-chan error) | ||
| } | ||
|
|
||
| // NewClient creates a new instance of Client | ||
| func NewClient() Client { | ||
| func NewClient(filter string) Client { |
There was a problem hiding this comment.
Added this so that it always filters regardless of callers.
amir20
commented
Jul 22, 2019
| @@ -39,6 +40,7 @@ func init() { | |||
| pflag.String("base", "/", "base address of the application to mount") | |||
| pflag.String("level", "info", "logging level") | |||
| pflag.Int("tailSize", 300, "Tail size to use for initial container logs") | |||
| pflag.String("filterName", "", "Filters containers by name") | |||
There was a problem hiding this comment.
Used filterName instead to be similar to docker manual
|
All tests pass. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamzero1 I moved some tests around. I also fixed some of the code so that the logic for finding the right container is push back to the
docker.Client