Translation related patches #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the appstream project no longer supports `translatable=no` properties, and gettext extract the `translatable=no` marked strings as translatable. I opened an issue to inform about the situation, but `translatable=no` properties are not accepted by developers. You can find the issue here: `https://github.com/ximion/appstream/issues/623` **Please test your script or string extraction process before merging this PR.** > In MetaInfo files, each individual paragraph of a description > (or enumerated entry) is translated individually, however, > you can only exclude the complete block from being translated > by adding `translate="no"` to the description element. Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
Flathub requires a developer tag and developer ID. > A developer tag with a name child tag must be present. Only one developer tag is allowed and the name tag also must be present only once in untranslated form. ``` <developer id="tld.vendor"> <name>Developer name</name> </developer> ``` Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name
That way it's easy to catch a translatable string.
yakushabb
changed the title
translate=no properties
|
@yakushabb I tested |
amit9838
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appdata:
translate=nopropertiesIt appears that the appstream project no longer supports
translatable=noproperties, and gettext extract thetranslatable=nomarked strings as translatable.I opened an issue to inform about the situation, but
translatable=noproperties are not accepted by developers. You can find the issue here:https://github.com/ximion/appstream/issues/623Please test your script or string extraction process before merging this PR.
Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
appdata: Add developer ID
Flathub requires a developer tag and developer ID.
Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name
i18n: Use C_ alias for pgettext
That way it's easy to catch a translatable string.