-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Review Suggestions #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2024
Closed
Hi @amkrajewski, this PR looks very helpful to get openjournals/joss-reviews#6731 moving forward. Is there anything blocking its review and merge? |
@RMeli Thanks for the ping! I was waiting for Reviewer 3 before making any modifications (which I got last week). I am traveling right now, but I should be able to start working on revisions soon and finish them next week. |
amkrajewski
approved these changes
Jul 27, 2024
Glad it helped! |
amkrajewski
added a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3
This PR attempts to resolve some of the suggestions from my review, along with a handful of typo fixes and similar edits.
Please feel free to accept or reject any of the changes in this PR. Some changes to benchmarks and Dockerfiles are slightly opinionated. If you want to reject any changes, you can just comment on the PR where you want to keep the current code, and revert the commits where those changes were made. (e.g.
git revert 7a9840b
) That will make it easier to track.