Misc. cleanup #78
Merged
Misc. cleanup #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was highlighted as an unused variable and I am pretty sure it was meant to be a part of the assertion so I have added a simple expect to cover that.
- This is not a semantic change but helps make it clear that the assignment is intended.
dgollahon
force-pushed
the
address-linter-flags
branch
from
0581225
to
354146e
Compare
|
@dgollahon thanks, this is much appreciated! i'll add rubocop one of these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was an unused variable in the quantifier spec when I was trying to find a spot to write tests for #77. I think it was meant to be used as an assertion so I added it in the first commit here.
Since I noticed that unused variable by chance, I decided to run
rubocop --lintand found a few other minor issues that felt like they might be worth a quick fixup. Feel free to reject these changes or I can drop commits you don't like but I thought they were all small improvements.You might consider adding a minimal
rubocopconfig with some basic linting and such enabled to avoid small items like these if you like these changes. If you don't, that's fine too.